This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
feat: remove useHead artifacts
#8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlan-zw
commented
Sep 3, 2022
|
I like the stripping of the artifacts from vueuse/head. But we might need to refine the implementation for the other prefetches. I don't want to do anything to remove anything the user has added, though of course you're right that we don't want nuxt/content's prefetches. Do you think there is a way to tell these apart? |
harlan-zw
changed the title
|
Good point, I've removed the prefetching removal code. I'll send a PR to the @nuxt/content module to add a config for toggling the prefetching |
harlan-zw
changed the title
harlan-zw
changed the title
useHead artifacts
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the module removing scripts from the HTML, there are a few artifacts left over which aren't being used for anything.
This PR removes Nuxt core ones (useHead) and pre-fetch API links from @nuxt/content.
I'm interested in your thoughts, and quite happy to close this PR if you think it doesn't belong.
It may cause issues if / when island hydration is supported and I haven't done much coverage with the tests.